Seth/sethLabels
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Pointer cleanup (#242)

Browse Source 
- Made greater use of smart pointers, eliminating many instances of manual memory management
- Do not use pointers at all for many non-polymorphic classes
- Assorted other code cleanup
This commit is contained in:
Jaye Evins
2025-10-31 16:11:28 -04:00
committed by GitHub
parent fd10d88be5
commit 8c8e447336
159 changed files with 3364 additions and 4045 deletions
Download Patch File Download Diff File Expand all files Collapse all files
glabels/VariablesView.cpp
+8 -17
View File
@@ -82,15 +82,6 @@ namespace glabels
}
///
/// Destructor
///
VariablesView::~VariablesView()
{
// empty
}
///
/// Set Model
///
@@ -132,7 +123,7 @@ namespace glabels
if ( dialog.exec() == QDialog::Accepted )
{
mModel->variables()->addVariable( dialog.variable() );
mModel->variables().addVariable( dialog.variable() );
selectVariable( dialog.variable().name() );
}
}
@@ -146,9 +137,9 @@ namespace glabels
int iRow = table->selectedItems()[0]->row();
QString name = table->item( iRow, I_COL_NAME )->text();
if ( mModel->variables()->hasVariable( name ) )
if ( mModel->variables().hasVariable( name ) )
{
model::Variable v = mModel->variables()->value( name );
model::Variable v = mModel->variables().value( name );
EditVariableDialog dialog( this );
dialog.setVariable( v );
@@ -156,7 +147,7 @@ namespace glabels
if ( dialog.exec() == QDialog::Accepted )
{
mModel->variables()->replaceVariable( name, dialog.variable() );
mModel->variables().replaceVariable( name, dialog.variable() );
selectVariable( dialog.variable().name() );
}
}
@@ -171,7 +162,7 @@ namespace glabels
int iRow = table->selectedItems()[0]->row();
QString name = table->item( iRow, I_COL_NAME )->text();
mModel->variables()->deleteVariable( name );
mModel->variables().deleteVariable( name );
}
@@ -203,10 +194,10 @@ namespace glabels
void VariablesView::loadTable()
{
table->clearContents();
table->setRowCount( mModel->variables()->size() );
table->setRowCount( mModel->variables().size() );
int iRow = 0;
for( const auto& v : *mModel->variables() )
for( const auto& v : mModel->variables() )
{
auto* typeItem = new QTableWidgetItem( model::Variable::typeToI18nString(v.type()) );
typeItem->setFlags( typeItem->flags() ^ Qt::ItemIsEditable );
@@ -237,7 +228,7 @@ namespace glabels
void VariablesView::selectVariable( const QString& name )
{
int iRow = 0;
for( const auto& v : *mModel->variables() )
for( const auto& v : mModel->variables() )
{
if ( v.name() == name )
{